-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add android support for transceiver api and sdp unified plan #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of formatting changes so review with whitespace changes hidden!
@@ -1,16 +1,27 @@ | |||
buildscript { | |||
repositories { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made these changes to get the project building standalone (outside the host react native repo). I used npx create-react-native-library
and copied the build.gradle
that was generated
@@ -172,35 +170,25 @@ private void transitionToCurrentCallMode(Mode previousMode) { | |||
} | |||
|
|||
private void requestAudioFocus() { | |||
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how they ever got this building. Build.VERSION_CODES.O
requires android sdk 26 and if that's the min sdk version then this condition will always we true
@@ -41,7 +41,8 @@ | |||
"devDependencies": { | |||
"husky": "7.0.2", | |||
"lint-staged": "11.2.3", | |||
"prettier": "2.4.1" | |||
"prettier": "2.4.1", | |||
"react-native": "^0.69.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-native deps are required to build, so adding this as a dev dep
android/src/main/java/com/oney/WebRTCModule/PeerConnectionObserver.java
Outdated
Show resolved
Hide resolved
Keep onAddStream in PeerConnectionObserver
…ets stick with that
…erConnectionAddedStream responses
Ported from react-native-webrtc#773